Project:
FindBugs version: 3.0.1
Code analyzed:
105553 lines of code analyzed, in 961 classes, in 16 packages.
| Metric | Total | Density* |
|---|---|---|
| High Priority Warnings | 1 | 0.01 |
| Medium Priority Warnings | 37 | 0.35 |
| Total Warnings | 38 | 0.36 |
(* Defects per Thousand lines of non-commenting source statements)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 20 |
| Correctness Warnings | 1 |
| Malicious code vulnerability Warnings | 1 |
| Dodgy code Warnings | 16 |
| Total | 38 |
Click on a warning row to see full context information.
| Code | Warning |
|---|---|
| Nm | The class name edu.jas.application.FactorFactory shadows the simple name of the superclass edu.jas.ufd.FactorFactory |
| OS | edu.jas.application.RunGB.getReader(String) may fail to close stream |
| RV | edu.jas.poly.PolynomialComparator.compare(GenPolynomial, GenPolynomial) negates the return value of edu.jas.poly.GenPolynomial.compareTo(GenPolynomial) |
| RV | edu.jas.poly.TermOrder$69.compare(ExpVector, ExpVector) negates the return value of edu.jas.poly.TermOrder$EVComparator.compare(ExpVector, ExpVector) |
| RV | edu.jas.poly.TermOrder$9.compare(ExpVector, ExpVector) negates the return value of edu.jas.poly.TermOrder$EVComparator.compare(ExpVector, ExpVector) |
| RV | edu.jas.poly.Word.gradInvlexCompareTo(Word) negates the return value of edu.jas.poly.Word.compareTo(Word) |
| SnVI | edu.jas.gb.GBProxy is Serializable; consider declaring a serialVersionUID |
| SnVI | edu.jas.gb.GroebnerBaseDistributed is Serializable; consider declaring a serialVersionUID |
| SnVI | edu.jas.gb.GroebnerBaseDistributedEC is Serializable; consider declaring a serialVersionUID |
| SnVI | edu.jas.gb.GroebnerBaseDistributedHybrid is Serializable; consider declaring a serialVersionUID |
| SnVI | edu.jas.gb.GroebnerBaseDistributedHybridEC is Serializable; consider declaring a serialVersionUID |
| SnVI | edu.jas.gb.GroebnerBaseParallel is Serializable; consider declaring a serialVersionUID |
| SnVI | edu.jas.gb.GroebnerBaseSeqPairDistributed is Serializable; consider declaring a serialVersionUID |
| SnVI | edu.jas.gb.GroebnerBaseSeqPairParallel is Serializable; consider declaring a serialVersionUID |
| SnVI | edu.jas.gb.SGBProxy is Serializable; consider declaring a serialVersionUID |
| SnVI | edu.jas.gb.SolvableGroebnerBaseParallel is Serializable; consider declaring a serialVersionUID |
| SnVI | edu.jas.gb.SolvableGroebnerBaseSeqPairParallel is Serializable; consider declaring a serialVersionUID |
| SnVI | edu.jas.gbufd.GroebnerBasePseudoParallel is Serializable; consider declaring a serialVersionUID |
| SnVI | edu.jas.gbufd.GroebnerBasePseudoRecParallel is Serializable; consider declaring a serialVersionUID |
| SnVI | edu.jas.ufd.GCDProxy is Serializable; consider declaring a serialVersionUID |
| Code | Warning |
|---|---|
| SA | Self comparison of edu.jas.ps.UnivPowerSeries.equals(Object) with itself edu.jas.ps.Examples.example11() |
| Code | Warning |
|---|---|
| MS | edu.jas.kern.ComputerThreads.NO_THREADS isn't final and can't be protected from malicious code |
| Code | Warning |
|---|---|
| BC | Unchecked/unconfirmed cast from edu.jas.poly.GenPolynomial<C> to edu.jas.poly.GenSolvablePolynomial in edu.jas.application.SolvableLocalResidueRing.create(GenPolynomial) |
| BC | Unchecked/unconfirmed cast from edu.jas.poly.GenPolynomial<C> to edu.jas.poly.GenSolvablePolynomial in edu.jas.application.SolvableLocalResidueRing.create(GenPolynomial, GenPolynomial) |
| BC | Unchecked/unconfirmed cast from edu.jas.poly.GenPolynomial<C> to edu.jas.poly.GenSolvablePolynomial in edu.jas.application.SolvableLocalRing.create(GenPolynomial) |
| BC | Unchecked/unconfirmed cast from edu.jas.poly.GenPolynomial<C> to edu.jas.poly.GenSolvablePolynomial in edu.jas.application.SolvableLocalRing.create(GenPolynomial, GenPolynomial) |
| BC | Unchecked/unconfirmed cast from edu.jas.poly.GenPolynomial<C> to edu.jas.poly.GenSolvablePolynomial in edu.jas.application.SolvableResidueRing.create(GenPolynomial) |
| BC | Unchecked/unconfirmed cast from edu.jas.poly.GenPolynomial<C> to edu.jas.poly.GenSolvablePolynomial in edu.jas.application.SolvableResidueRing.create(GenPolynomial, GenPolynomial) |
| BC | Unchecked/unconfirmed cast from edu.jas.poly.GenPolynomial<C> to edu.jas.poly.GenSolvablePolynomial in edu.jas.gbufd.SolvableQuotientRing.create(GenPolynomial) |
| BC | Unchecked/unconfirmed cast from edu.jas.poly.GenPolynomial<C> to edu.jas.poly.GenSolvablePolynomial in edu.jas.gbufd.SolvableQuotientRing.create(GenPolynomial, GenPolynomial) |
| BC | instanceof will always return true for all non-null values in edu.jas.poly.RecSolvablePolynomial.evalAsRightRecursivePolynomial(), since all edu.jas.poly.RecSolvablePolynomial are instances of edu.jas.poly.RecSolvablePolynomial |
| BC | instanceof will always return true for all non-null values in edu.jas.poly.RecSolvablePolynomial.isRightRecursivePolynomial(GenSolvablePolynomial), since all edu.jas.poly.RecSolvablePolynomial are instances of edu.jas.poly.RecSolvablePolynomial |
| BC | instanceof will always return true for all non-null values in edu.jas.poly.RecSolvablePolynomial.rightRecursivePolynomial(), since all edu.jas.poly.RecSolvablePolynomial are instances of edu.jas.poly.RecSolvablePolynomial |
| DB | edu.jas.application.RingFactoryTokenizer.nextCoefficientRing() uses the same code for two branches |
| DB | edu.jas.poly.GenPolynomialTokenizer.nextCoefficientRing() uses the same code for two branches |
| DLS | Dead store to $L10 in edu.jas.ufd.GreatestCommonDivisorHensel.recursiveUnivariateGcd(GenPolynomial, GenPolynomial) |
| SF | Switch statement found in edu.jas.poly.GenPolynomialTokenizer.nextPolynomial() where one case falls through to the next case |
| UC | Useless object stored in variable var$7 of method edu.jas.ufd.GreatestCommonDivisorHensel.invertPoly(ModularRingFactory, GenPolynomial, List) |
This instanceof test will always return true (unless the value being tested is null). Although this is safe, make sure it isn't an indication of some misunderstanding or some other logic error. If you really want to test the value for being null, perhaps it would be clearer to do better to do a null test rather than an instanceof test.
This cast is unchecked, and not all instances of the type casted from can be cast to the type it is being cast to. Check that your program logic ensures that this cast will not fail.
This method uses the same code to implement two branches of a conditional branch. Check to ensure that this isn't a coding mistake.
This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction. Often, this indicates an error, because the value computed is never used.
Note that Sun's javac compiler often generates dead stores for final local variables. Because FindBugs is a bytecode-based tool, there is no easy way to eliminate these false positives.
A mutable static field could be changed by malicious code or by accident from another package. Unfortunately, the way the field is used doesn't allow any easy fix to this problem.
This class has a simple name that is identical to that of its superclass, except
that its superclass is in a different package (e.g., alpha.Foo extends beta.Foo).
This can be exceptionally confusing, create lots of situations in which you have to look at import statements
to resolve references and creates many
opportunities to accidentally define methods that do not override methods in their superclasses.
The method creates an IO stream object, does not assign it to any
fields, pass it to other methods that might close it,
or return it, and does not appear to close
the stream on all paths out of the method. This may result in
a file descriptor leak. It is generally a good
idea to use a finally block to ensure that streams are
closed.
This code negatives the return value of a compareTo or compare method. This is a questionable or bad programming practice, since if the return value is Integer.MIN_VALUE, negating the return value won't negate the sign of the result. You can achieve the same intended result by reversing the order of the operands rather than by negating the results.
This method compares a local variable with itself, and may indicate a typo or a logic error. Make sure that you are comparing the right things.
This method contains a switch statement where one case branch will fall through to the next case. Usually you need to end this case with a break or return.
This class implements the Serializable interface, but does
not define a serialVersionUID field.
A change as simple as adding a reference to a .class object
will add synthetic fields to the class,
which will unfortunately change the implicit
serialVersionUID (e.g., adding a reference to String.class
will generate a static field class$java$lang$String).
Also, different source code to bytecode compilers may use different
naming conventions for synthetic variables generated for
references to class objects or inner classes.
To ensure interoperability of Serializable across versions,
consider adding an explicit serialVersionUID.
Our analysis shows that this object is useless. It's created and modified, but its value never go outside of the method or produce any side-effect. Either there is a mistake and object was intended to be used or it can be removed.
This analysis rarely produces false-positives. Common false-positive cases include:
- This object used to implicitly throw some obscure exception.
- This object used as a stub to generalize the code.
- This object used to hold strong references to weak/soft-referenced objects.